Skip to content

Added test for assert_index_equal to check that function raises an exception if two different types #48351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

MrShevan
Copy link
Contributor

@MrShevan MrShevan commented Sep 1, 2022

@MrShevan MrShevan marked this pull request as ready for review September 1, 2022 21:32
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Sep 2, 2022
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke if you have anything else for this PR

@mroeschke mroeschke added this to the 1.6 milestone Sep 2, 2022
@mroeschke mroeschke merged commit a72340a into pandas-dev:main Sep 2, 2022
@mroeschke
Copy link
Member

Thanks @MrShevan

@MrShevan
Copy link
Contributor Author

MrShevan commented Sep 3, 2022

@mroeschke no problems! :)

@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…exception if two different types (pandas-dev#48351)

* added test for `assert_index_equal` function

* added test for `assert_index_equal` function

* added test for `assert_index_equal` function

Co-authored-by: Anton Shevtsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tm.assert_index_equal broken with pd.NA and np.NaT sentinel
3 participants